fix: source Interests top-level nav label from feature/interests module#2113
Open
Noahs212 wants to merge 1 commit into
Open
fix: source Interests top-level nav label from feature/interests module#2113Noahs212 wants to merge 1 commit into
Noahs212 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the 'Interests' navigation item and its associated UI tests to use string resources from the interests feature module instead of the search feature module. This involves updating imports and resource references in TopLevelNavItem.kt and NavigationTest.kt to improve modularity. I have no feedback to provide as the existing review comments were purely explanatory and did not identify any issues or improvement opportunities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INTERESTSinapp/.../navigation/TopLevelNavItem.ktfromsearchR.string.feature_search_api_intereststointerestsR.string.feature_interests_api_title. The previously-orphanedfeature_interests_api_titleresource (added on 2025-11-19 in068d8ccduring the api/impl module split, never wired up) is now the source of truth for the Interests bottom-nav label.FOR_YOU/BOOKMARKSentries.NavigationTest.ktto read the interests label from the interests module's resource, matching the production change.User-visible behavior is unchanged — both strings have the value
"Interests", so existing tests, screenshots, and snapshots stay green. Thefeature_search_api_interestsresource in the search module is untouched and still used bySearchScreen.kt:248andSearchScreenTest.kt:83.Fixes #2112
Test plan
./gradlew spotlessApply./gradlew :app:assembleDemoDebug./gradlew :app:lintDemoDebug./gradlew :app:connectedDemoDebugAndroidTest --tests "*NavigationTest*"(needs emulator/device)