Skip to content

fix: source Interests top-level nav label from feature/interests module#2113

Open
Noahs212 wants to merge 1 commit into
android:mainfrom
Noahs212:fix/interests-toplevel-nav-string
Open

fix: source Interests top-level nav label from feature/interests module#2113
Noahs212 wants to merge 1 commit into
android:mainfrom
Noahs212:fix/interests-toplevel-nav-string

Conversation

@Noahs212
Copy link
Copy Markdown

Summary

  • Switch INTERESTS in app/.../navigation/TopLevelNavItem.kt from searchR.string.feature_search_api_interests to interestsR.string.feature_interests_api_title. The previously-orphaned feature_interests_api_title resource (added on 2025-11-19 in 068d8cc during the api/impl module split, never wired up) is now the source of truth for the Interests bottom-nav label.
  • Restores the per-module-ownership pattern used by the sibling FOR_YOU / BOOKMARKS entries.
  • Eliminates the silent cross-feature coupling: changing the in-search "Interests" link copy at SearchScreen.kt:248 no longer also rewrites the bottom-nav tab.
  • Updates NavigationTest.kt to read the interests label from the interests module's resource, matching the production change.

User-visible behavior is unchanged — both strings have the value "Interests", so existing tests, screenshots, and snapshots stay green. The feature_search_api_interests resource in the search module is untouched and still used by SearchScreen.kt:248 and SearchScreenTest.kt:83.

Fixes #2112

Test plan

  • ./gradlew spotlessApply
  • ./gradlew :app:assembleDemoDebug
  • ./gradlew :app:lintDemoDebug
  • ./gradlew :app:connectedDemoDebugAndroidTest --tests "*NavigationTest*" (needs emulator/device)
  • Manually verify the Interests bottom-nav tab still reads "Interests" on a launched debug build.

@Noahs212 Noahs212 requested a review from dturner as a code owner May 17, 2026 21:41
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'Interests' navigation item and its associated UI tests to use string resources from the interests feature module instead of the search feature module. This involves updating imports and resource references in TopLevelNavItem.kt and NavigationTest.kt to improve modularity. I have no feedback to provide as the existing review comments were purely explanatory and did not identify any issues or improvement opportunities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Interests top-level nav label sources string from feature/search instead of feature/interests

1 participant