[FEATURE] Introduce ProcessorSkipper for conditional processor execution#339
Open
chrissonntag wants to merge 1 commit intoandreaswolf:mainfrom
Open
[FEATURE] Introduce ProcessorSkipper for conditional processor execution#339chrissonntag wants to merge 1 commit intoandreaswolf:mainfrom
chrissonntag wants to merge 1 commit intoandreaswolf:mainfrom
Conversation
Collaborator
|
Can you let your AI also write some tests for it? |
Contributor
Author
|
Sure thing, will do. I'm getting back to it tomorrow |
Contributor
Author
|
I'd say, I delay the implementation of any tests until we have decided how to proceed with the whole skipping thing ;-) There is a chance that this PR is already obsolete. |
Collaborator
|
please rebase this PR and resolve the conflict |
- ✨ Added ProcessorSkipper class to manage processor skipping logic. - 🔧 Integrated ProcessorSkipper into FractorRunner and AllowedFileExtensionsResolver to conditionally skip processors based on configuration. - 📜 Updated SkipConfiguration to support processor skipping configurations.
d058ac2 to
c8949e5
Compare
Contributor
Author
Done, should be good to go to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce ProcessorSkipper for a distinguished processor execution
Summary
This PR adds the
ProcessorSkipperclass to enable conditional skipping of file processors based on configuration, which addresses issue #209. The feature allows more granular control over which processors are executed, improving flexibility for complex scenarios.Key Changes
ProcessorSkipperis now injected and used in bothFractorRunnerandAllowedFileExtensionsResolverto skip processors as configured.SkipConfigurationandFractorConfigurationBuilderupdated to support processor skipping alongside rule/path skipping.Details
Example