Repository navigation
Preserve split tunneling when subscription settings are omitted - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing a v8 subscription with only profiles and subscription endpoints still switched locally configured split tunneling to Global VPN. The parser constructed global defaults for every v2+ document, and snapshot application replaced local settings with routeAllApps=true even when routing was absent.
Track which global fields were actually supplied and merge only those fields against current storage inside the existing transaction. Apply the same behavior to manual imports. Omitted diagnostic log limits are also preserved; explicit settings, including an empty app selection, still apply. Preserve the legacy v2/v3 SSH fingerprint migration.
Regression coverage exercises a minimal snapshot, a partial TLS/routing snapshot, edits made after parsing, explicit global routing and diagnostic limits, persisted settings and reconnect behavior.
Validation: all 290 JVM tests passed through Bundler/Fastlane; lintDebug, assembleDebug and assembleRelease passed. Verified the release APK remains unsigned. Native sources are unchanged; local validation reused the existing native AAR after native rebuild was interrupted by a Go dependency download error. Emulator checks will run in PR CI.
Both deployed server APIs were rechecked for generic, Android, Firefox and Chromium responses: they omit routing. This fix requires an updated Android APK; server deployment alone cannot change the installed client's parsing behavior.