Repository navigation
Recognize JOIN before parenthesized subqueries - #919
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JOIN(SELECT ...)is currently consumed by the function-name lookahead. As aresult,
child join(...) as pbecomes a singleIdentifierinstead of a table,JOIN keyword and subquery alias.
Move the existing JOIN regex ahead of that lookahead, keeping it after the dotted
name guards. The regression covers bare and compound JOINs, subquery aliases,
unchanged SQL text, ordinary function names and
schema.join(...).Refs #615's JOIN example; this does not change UNNEST or ANY classification.
Validation on Windows / Python 3.14.3 / pytest 9.0.3:
patched source passes all 10.
also occur on the unchanged-source baseline.
ruff check sqlparse/ tests/test_join_parenthesis.pyandgit diff --checkpass.SQLite 3.50.4; no cross-dialect qualification is claimed.
Prepared with AI assistance.
Thanks for contributing!
Before submitting your pull request please have a look at the
following checklist:
pytest)ruff)In addition, please take care to provide a proper description
on what your change does, fixes or achieves when submitting the
pull request.
Note: This repository has automated AI code reviews enabled to help catch
potential issues early and provide suggestions. This is an experimental
feature to support maintainers and contributors – your feedback is welcome!