Repository navigation
image: boot the qcow2 in image.vm - #383
Merged
Merged
Conversation
Commit e0bd4df removed the huge sparse holes from raw disks, and moved them to `virtual_size`. But that broke `image.vm()`: that still booted the raw disk, which has no more room to grow into. Switch it over to booting the qcow, which has always been the intention: qcow is for VMs, raw for real iron. This again makes the `grow` option unnecessary in most cases. But keep it as it's still a nice and cheap way to test-boot a guest that needs more room than `virtual_size`. Signed-off-by: Martin Pitt <martin@amutable.com>
daandemeyer
approved these changes
Nov 4, 2026
martinpitt
enabled auto-merge (rebase)
November 4, 2026 08:51
martinpitt
disabled auto-merge
November 4, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit e0bd4df removed the huge sparse holes from raw disks, and moved them to
virtual_size. But that brokeimage.vm(): that still booted the raw disk, which has no more room to grow into.Switch it over to booting the qcow, which has always been the intention: qcow is for VMs, raw for real iron.
This again makes the
growoption unnecessary in most cases. But keep it as it's still a nice and cheap way to test-boot a guest that needs more room thanvirtual_size.Tested with
bin/tine buck run //examples/image:boot-demo-vm.fedorawhich hasvirtual_size = 2G. Before:now:
Also verified that qemu runs the qcow instead of the raw.