Repository navigation
image: Copy release artifacts instead of symlinking them - #381
Merged
Merged
Conversation
image.artifacts() assembles the release as a directory of symlinks. systemd-sysupdate ignores symlinks when it lists a transfer's source directory, so it finds no files to update from. Let's copy the files instead. Buck copies them with copy_file_range, which shares the blocks of the disk images on btrfs and XFS. Signed-off-by: Daan De Meyer <daan@amutable.com>
martinpitt
approved these changes
Nov 3, 2026
martinpitt
left a comment
martinpitt
left a comment
Member
There was a problem hiding this comment.
This will increase buck-out/ even more on e.g. an ext4 system (somebody think of the childr, err, GitHub action runners!) Is this for local testing? sysupdate would not normally run from a local user build tree?
I suppose you have a good reason, so approving, I'm just curious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image.artifacts() assembles the release as a directory of symlinks.
systemd-sysupdate ignores symlinks when it lists a transfer's source
directory, so it finds no files to update from. Let's copy the files
instead. Buck copies them with copy_file_range, which shares the blocks
of the disk images on btrfs and XFS.