Repository navigation
Conversation
Any failure to fetch a repo's first root.json skipped the repo. A machine that could not authenticate then updated nothing and still reported success. Now only a missing root.json, which means the repo may not exist yet, skips the repo. Any other failure is an error, so one repo that fails this way stops the whole run. Signed-off-by: Joaquim Rocha <joaquim@amutable.com> Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
cyphar
commented
Nov 3, 2026
Comment on lines
+93
to
+99
| // Only a missing root.json means the repository may not exist | ||
| // yet. Any other failure (auth, network, server error) must not | ||
| // look like an empty repository list. | ||
| if errors.Is(err, fs.ErrNotExist) { | ||
| err = skippableErr(err) | ||
| } | ||
| return nil, err |
Member
Author
There was a problem hiding this comment.
I'm not sure this is actually correct -- if I configure a repository with broken auth (or a repository where the server hasn't yet allowed access to this client) then I think the behaviour should be the same as if I configured a repository that does not exist.
If the
root_trustis configured to wait until the repository is accessible, I don't think 404s are less problematic than 403s. And again, this only applies to first-pull (and eventually this will not be used by AOS anyway).I've moved this to a separate PR -- #95.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #82, as I'm not convinced it's correct.
Any failure to fetch a repo's first root.json skipped the repo. A
machine that could not authenticate then updated nothing and still
reported success.
Now only a missing root.json, which means the repo may not exist yet,
skips the repo. Any other failure is an error, so one repo that fails
this way stops the whole run.
Signed-off-by: Joaquim Rocha joaquim@amutable.com
Signed-off-by: Aleksa Sarai aleksa@amutable.com