Repository navigation
sysupdate: take the tags snapshot before the first update pass - #93
Merged
Merged
Conversation
We loop over enable-suggested/update until the machine tags stop changing so that a confext that ships machine-tags.d files gets its features installed in the same run. The problem is that we took the "before" snapshot of the tags after the first update pass. But sysupdate already refreshes the confexts when it installs one and with the confext now having EXTENSION_RELOAD_OR_RESTART_UNITS=systemd-machine-tags.service the tags are applied right there. So the snapshot already contained the new tags, nothing changed after our own refresh and we only picked up the new features on the next timer run. This commit moves the snapshot before the first pass. Signed-off-by: Michael Vogt <michael@amutable.com>
pothos
approved these changes
Nov 2, 2026
cyphar
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We loop over enable-suggested/update until the machine tags stop changing so that a confext that ships machine-tags.d files gets its features installed in the same run.
The problem is that we took the "before" snapshot of the tags after the first update pass. But sysupdate already refreshes the confexts when it installs one and with the confext now having EXTENSION_RELOAD_OR_RESTART_UNITS=systemd-machine-tags.service the tags are applied right there. So the snapshot already contained the new tags, nothing changed after our own refresh and we only picked up the new features on the next timer run.
This commit moves the snapshot before the first pass.