Snarks enemy selection rework by MyGamepedia · Pull Request #358 · ampreeT/SourceCoop

MyGamepedia · 2026-02-22T08:05:39Z

Fixes #300
Replaces teamnum value to make IsValidEnemy() pass players even if mp_teamplay is enabled to make snarks aggressive to all players, just like in sp/dm. Filtered map-placed snarks for certain reasons.
Includes ENTPATCH_BM_SNARK macro.

MyGamepedia · 2026-02-22T08:18:19Z

okay, this doesn't work somehow, i'll rework it.

MyGamepedia · 2026-02-22T09:05:06Z

Turns out this needs to be done with a delay.

ampreeT · 2026-02-22T22:00:11Z

Hey I don't think that implementing snark aggression against players is a good idea as it would be easier to grief (spawn, throw snarks, suicide, repeat). In fact, it may be better for snarks to ignore players/friendly npcs regardless of mp_teamplay and to instead use mp_friendlyfire to dictate snark aggression. @Alienmario wdyt?

Alienmario · 2026-02-22T22:20:47Z

Yeah, mp_friendlyfire makes sense here.

MyGamepedia · 2026-02-22T22:46:23Z

Hey I don't think that implementing snark aggression against players is a good idea as it would be easier to grief (spawn, throw snarks, suicide, repeat). In fact, it may be better for snarks to ignore players/friendly npcs regardless of mp_teamplay and to instead use mp_friendlyfire to dictate snark aggression. @Alienmario wdyt?

good idea.

- Added hook for IsValidEnemy on snark to filter ally NPC and teammates. - Added IsPlayerAlly method for CAI_BaseNPC methodmap. - Added CNpc_Snark methodmap from necro_multipatch.

MyGamepedia · 2026-02-24T00:04:54Z

Hey I don't think that implementing snark aggression against players is a good idea as it would be easier to grief (spawn, throw snarks, suicide, repeat). In fact, it may be better for snarks to ignore players/friendly npcs regardless of mp_teamplay and to instead use mp_friendlyfire to dictate snark aggression. @Alienmario wdyt?

Done in the way as described here. Guard and scientists still aren't happy to see player's snarks, but I guess it's fine ?

MyGamepedia · 2026-03-04T17:46:29Z

I have working filter for ally NPCs now, the only issue is that they still can ask for help.

but security still asks for help due to how it's done in the code, i tried using SetReletationship input on snarks, but i still have to idea why it says that the syntax is incorrect

MyGamepedia · 2026-03-05T07:59:22Z

No ally agro on snarks now, but security still asks for help due to how it's done in the code, i tried using SetReletationship input on snarks, but i still have to idea why it says that the syntax is incorrect.

ampreeT

Tested on Linux Dedicated server. Implementation is working as described and looks good to me. Did you test on a Windows server?

Fix up the syntax/styling issues and we can get this merged in. Thanks!

ampreeT · 2026-03-26T20:19:37Z

+    CAI_BaseNPC pEnemy = CAI_BaseNPC(DHookGetParam(hParams, 1));
+
+	//not valid target
+    if (!pEnemy.IsValid())


Change this line to if (pEnemy == NULL_CBASEENTITY)

ampreeT · 2026-03-26T20:25:37Z

+
+	if (strcmp(szClassname, "npc_snark") == 0)
+	{
+		CBasePlayer pOwner = CBasePlayer(CNpc_Snark(pEnemy.entindex).GetSnarkOwner());


Methodmap function GetSnarkOwner currently returns int. It should return CBaseEntity. When that is fixed, change this line to:

CNpc_Snark pSnark = view_as<CNpc_Snark>(pEnemy); CBaseEntity pOwner = pSnark.GetSnarkOwner(); ... // cast to player if it is still needed after checking entity is valid player

ampreeT · 2026-03-27T18:48:16Z

+//------------------------------------------------------
+public void Hook_Snark_OnCreated(const int iEntIndex)
+{
+	if (CBaseEntity(iEntIndex).GetHammerID() != 0) //don't for map-placed


Change to:

CNpc_Snark pSnark = CNpc_Snark(iEntIndex); if (pSnark.GetHammerID() != 0) //don't for map-placed

ampreeT · 2026-03-27T18:50:14Z

+	if (CBaseEntity(iEntIndex).GetHammerID() != 0) //don't for map-placed
+        return;
+
+    CBasePlayer pPlayer = CBasePlayer(CNpc_Snark(iEntIndex).GetSnarkOwner());


Change to:

CBaseEntity pOwner = pSnark.GetSnarkOwner(); if (pOwner == NULL_CBASEENTITY || !pOwner.IsPlayer()) return; CBasePlayer pPlayer = view_as<CBasePlayer>(pOwner);

ampreeT · 2026-03-27T18:51:18Z

+        return;
+
+    int iTeam = (mp_friendlyfire.BoolValue) ? TEAM_ANY : pPlayer.GetTeam();
+	SetEntProp(iEntIndex, Prop_Data, "m_iInitialTeamNum", iTeam);


Change to:

pSnark.SetInitialTeam(iTeam); pSnark.SetTeam(iTeam);

ampreeT · 2026-03-27T18:52:39Z

+        return MRES_Ignored;
+
+    CAI_BaseNPC pEnemy = CAI_BaseNPC(DHookGetParam(hParams, 1));
+    if (!pEnemy.IsValid())


Change to:

if (pEnemy == NULL_CBASEENTITY)

ampreeT · 2026-03-27T18:53:33Z

+        return MRES_Ignored;
+
+	//guard is PROVOKED
+    if (HasEntProp(pEnemy.entindex, Prop_Data, "m_afMemory") && pEnemy.m_afMemory & bits_MEMORY_PROVOKED)


Not familar with this implementation. What is the point of checking if the entity has the netprop m_afMemory?

ampreeT · 2026-03-27T18:55:07Z

+		SetEntPropFloat(this.entindex, Prop_Data, "m_fLifeTime", flLifeTime);
+	}
+
+	public int GetSnarkOwner()


Change this so it returns CBaseEntity:

public CBaseEntity GetSnarkOwner() { return CBaseEntity(GetEntPropEnt(this.entindex, Prop_Data, "m_hOwner")); }

ampreeT · 2026-03-27T18:57:14Z

+		return GetEntPropEnt(this.entindex, Prop_Data, "m_hOwner");
+	}
+
+	public void SetSnarkOwner(int iEntIndex)


Change this:

public void SetSnarkOwner(const CBaseEntity pOwner) { SetEntPropEnt(this.entindex, Prop_Data, "m_hOwner", pOwner.entindex); }

ampreeT · 2026-03-27T18:59:10Z

+		#if defined ENTPATCH_BM_SNARK
+		if (strcmp(szClassname, "npc_snark") == 0 && CoopManager.IsCoopModeEnabled())
+		{
+			RequestFrame(Hook_Snark_OnCreated, iEntIndex);


Instead of using RequestFrame, try using a post spawn hook here using SDKhooks

MyGamepedia · 2026-03-27T19:13:26Z

Tested on Linux Dedicated server. Implementation is working as described and looks good to me. Did you test on a Windows server?

Fix up the syntax/styling issues and we can get this merged in. Thanks!

I gonna try to fix sec guard issue first once I can dedicate the time again, i have an idea.

It was tested with listening servers on Windows.

MyGamepedia · 2026-03-30T12:19:43Z

Found few issues.

- now friend players checked early by team - not npc ents ignored - added method description in gamedata

added snark team reset if mp_teamplay == 1

399c16a

fixed (tested)

39e0046

MyGamepedia changed the title ~~Snarks not aggressive to players path for teamplay~~ Snarks enemy selection rework Feb 23, 2026

MyGamepedia added 2 commits February 24, 2026 02:01

rework

d72eadf

- Added hook for IsValidEnemy on snark to filter ally NPC and teammates. - Added IsPlayerAlly method for CAI_BaseNPC methodmap. - Added CNpc_Snark methodmap from necro_multipatch.

comp fix

1abaf5c

Update srccoop.sp

dcced24

MyGamepedia added 2 commits March 5, 2026 09:57

now ally npcs will not attack snarks

d47ae6f

but security still asks for help due to how it's done in the code, i tried using SetReletationship input on snarks, but i still have to idea why it says that the syntax is incorrect

Update srccoop.sp

3d8d5b2

ampreeT requested changes Mar 27, 2026

View reviewed changes

better code + no help ask from sec guard

d27c79a

MyGamepedia requested a review from ampreeT March 29, 2026 09:12

MyGamepedia added 4 commits March 29, 2026 12:14

prev commit fix

5bc831d

Update CBaseEntity.inc

f113c69

Update entitypatch.inc

1eda57e

Update entitypatch.inc

27f57f8

MyGamepedia marked this pull request as draft March 30, 2026 12:19

MyGamepedia added 2 commits April 20, 2026 10:14

few changes before fixing

191ff66

fixed

aceeaef

- now friend players checked early by team - not npc ents ignored - added method description in gamedata

MyGamepedia marked this pull request as ready for review April 20, 2026 07:39

now all players in the team we return true for IsPlayerAlly()

d882728

Update entitypatch.inc

1df3755

Conversation

MyGamepedia commented Feb 22, 2026

Uh oh!

MyGamepedia commented Feb 22, 2026

Uh oh!

MyGamepedia commented Feb 22, 2026

Uh oh!

ampreeT commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alienmario commented Feb 22, 2026

Uh oh!

MyGamepedia commented Feb 22, 2026

Uh oh!

MyGamepedia commented Feb 24, 2026

Uh oh!

MyGamepedia commented Mar 4, 2026

Uh oh!

MyGamepedia commented Mar 5, 2026

Uh oh!

ampreeT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MyGamepedia commented Mar 27, 2026

Uh oh!

MyGamepedia commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ampreeT commented Feb 22, 2026 •

edited

Loading