Skip to content

Consistent global limits for rate and channels#508

Open
twonoise wants to merge 8 commits into
alsa-project:masterfrom
twonoise:master
Open

Consistent global limits for rate and channels#508
twonoise wants to merge 8 commits into
alsa-project:masterfrom
twonoise:master

Conversation

@twonoise
Copy link
Copy Markdown

@twonoise twonoise commented May 31, 2026

PR for #507.

Signed-off-by: jpka mvv@mvv.su

@github-actions github-actions Bot added the signed off by Missing Signed-off-by: line. label May 31, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Signed-off-by Validation Issues

The following commits have issues with their Signed-off-by lines:

Commit fa797c8

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Commit cd7c5e3

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Commit 583de52

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Commit 2b58530

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Commit d99f2d7

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Commit bdaeccb

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Commit e70039a

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Commit 63ec4d2

Author: jpka mvv@mvv.su
Committer: GitHub noreply@github.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Each commit must include a proper Signed-off-by: Your Name <your.email@example.com> line. Additionally, both the commit author and committer emails must either match one of the Signed-off-by lines or use a valid (non-anonymous) email address.

Tip: You can inspect your commits locally using:

git log --format=fuller

Missing correct Signed-off-by line

This pull request has commits that are missing proper Signed-off-by lines or use invalid email addresses.

Requirements:

  • Each commit must include at least one Signed-off-by: Your Name <your.email@example.com> line
  • Commit author email must appear in at least one Signed-off-by line
  • Commit committer email must appear in at least one Signed-off-by line (if not a GitHub bot)
  • Multiple Signed-off-by lines are allowed for co-authored commits
  • Anonymous GitHub emails (like @users.noreply.github.com) are not allowed
  • The Signed-off-by line indicates that you agree to the Developer Certificate of Origin (DCO)

How to fix:

# 1. Configure your git identity first (if needed):
git config user.name "Your Name"
git config user.email "your.email@example.com"

# 2. For adding Signed-off-by to the last commit:
git commit --amend --signoff

# 3. For adding Signed-off-by to multiple commits:
git rebase -i HEAD~N --signoff

# 4. If commit author email is wrong, fix it:
# For the last commit only:
git commit --amend --author="Your Name <your.email@example.com>" --signoff

# For multiple commits:
git rebase -i HEAD~N
# Mark commits as 'edit', then for each:
git commit --amend --author="Your Name <your.email@example.com>" --signoff
git rebase --continue

# 5. For co-authored commits, add multiple Signed-off-by lines manually:
git commit --amend
# Then add in the commit message:
# Signed-off-by: Author One <author1@example.com>
# Signed-off-by: Author Two <author2@example.com>

# 6. Finally, force push your changes:
git push --force-with-lease

Reference: Developer Certificate of Origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

signed off by Missing Signed-off-by: line.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant