This repository was archived by the owner on Dec 6, 2024. It is now read-only.
Fix CreateJunction when the target is a volume-prefixed path#517
Open
rstarkov wants to merge 1 commit intoalphaleonis:developfrom
Open
Fix CreateJunction when the target is a volume-prefixed path#517rstarkov wants to merge 1 commit intoalphaleonis:developfrom
rstarkov wants to merge 1 commit intoalphaleonis:developfrom
Conversation
rstarkov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #516
I did not attempt to add a
PrintName, because the existing code didn't have it. It does not appear to make a difference.Also included is a unit test which fails without this change. Happy to tweak the way this test is invoked if you're not happy with how I've done it.