README says "Works on Mac, Windows, and Linux" — but CI only tests ubuntu-latest and macos-latest (verified in .github/workflows/ci.yml). Windows is claimed, never tested.
Fix: add windows-latest to the CI matrix. Known pitfalls to expect:
- Console encoding: the CLI prints Devanagari and emoji; on Windows runners set
PYTHONUTF8: "1" (env block) or PYTHONIOENCODING: utf-8
- The smoke-test loop step already uses
shell: bash, which works on Windows runners — verify the $(basename ...) logic still behaves
- Path handling in tests (prefer
pathlib)
Start with one Windows leg (e.g. py3.12): 2 OS × 4 versions + 1 = 9 jobs. If green, decide whether full Windows coverage is worth the minutes.
The ci-ok aggregate job automatically includes new matrix legs — no branch-protection changes needed.
README says "Works on Mac, Windows, and Linux" — but CI only tests
ubuntu-latestandmacos-latest(verified in.github/workflows/ci.yml). Windows is claimed, never tested.Fix: add
windows-latestto the CI matrix. Known pitfalls to expect:PYTHONUTF8: "1"(env block) orPYTHONIOENCODING: utf-8shell: bash, which works on Windows runners — verify the$(basename ...)logic still behavespathlib)Start with one Windows leg (e.g. py3.12): 2 OS × 4 versions + 1 = 9 jobs. If green, decide whether full Windows coverage is worth the minutes.
The
ci-okaggregate job automatically includes new matrix legs — no branch-protection changes needed.