Revamp Settings menu structure; add version footer (#112, #113)#140
Merged
Conversation
Split the settings by axis instead of the grown-organically mix: - General: language, temperature unit, and the status notification (show-rate moved here from the Battery Drain group) - Alerts: WHAT to be notified about — one category per alert event in battery-lifecycle order (levels slider moved from General, then warning, critical, full, temperature, fast drain, charging), so Temperature no longer sits between Warning and Critical - Notification Behaviour: HOW alerts sound/appear and WHEN they are allowed — silent-mode handling, vibrate, quiet hours (with "critical ignores quiet hours" moved next to the window it overrides), sticky Wording only, no logic changes (all preference keys and defaults are unchanged, so nothing migrates): - "Apply Silent Mode" -> "Mute alerts in silent mode" with summaries that say what ON does - Quiet-hours toggle/time labels and sticky summaries rewritten - Root headers get descriptive summaries - Fix swapped Arabic vibrate on/off summaries Version footer (#113): the Settings root now ends with a "Version x.y.z" row; tapping opens the About dialog. The dialog + version lookup moved from MainActivity into a shared AboutDialog helper. Also delete the unused pref_headers.xml / pref_headers_legacy.xml. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ZMe8rrw7eQKz69R4Xw3t5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112, closes #113.
What changed
Splits the settings by axis instead of the grown-organically mix (design settled in #112):
Version footer (#113): the Settings root now ends with a "Version x.y.z" row; tapping opens the About dialog. The dialog + version lookup moved from
MainActivityinto a sharedAboutDialoghelper.Wording only, no logic changes (all preference keys and defaults unchanged — nothing migrates):
Also deletes the unused
pref_headers.xml/pref_headers_legacy.xml.Verification
Static checks only in-session (the cloud env can't build yet, #137): XML parse-validation, all
@string/@arrayreferences resolve, two-way values ↔ values-ar diff clean, no dangling references to removed resources. CI on this PR is the compile gate; maintainer will test on device.🤖 Generated with Claude Code
https://claude.ai/code/session_015ZMe8rrw7eQKz69R4Xw3t5
Generated by Claude Code