Don't buffer text/event-stream response bodies#1351
Open
Yevhen-Bozhenko wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Relates to #1036.
AllureOkHttp3calledResponseBody.bytes()on every response.An SSE body only ends when the server closes the connection, so buffering it blocked the interceptor, and no events reached the client until the stream was over.
This skips body capture when the response is
text/event-streamand passes the body through untouched.Note the guard keys off
Content-Type, matching howokhttp-sseitself detects SSE - it is not a general "never buffer streaming bodies" fix.Checklist