Open
Conversation
…k and nx deployment workflows by using the environment for AWS credentials instead of inputs
TheOrangePuff
requested changes
Mar 27, 2026
| type: string | ||
| required: false | ||
| default: "ap-southeast-2" | ||
| s3-bucket: |
Member
There was a problem hiding this comment.
Instead of removing can we make this optional? And then they can override the defaults provided in the environment variables
| description: "AWS role session name for OIDC authentication (default: {repo}-{short-sha}-{run-number})" | ||
| type: string | ||
| required: true | ||
| cloudfront-distribution-id: |
Member
There was a problem hiding this comment.
Same with this, just don't make it required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Updating the PWA Deployment workflow to be more in line with our CDK and NX workflows by removing the AWS credential inputs and moving them to environment values.
Notes to PR author
Notes to reviewers
@aaronmedina-dev, this will require updates on the repos you have already migrated to use it.
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback