fix(abi): dynamic_cast error on Predicate across shared libraries#450
Open
zhangweilst wants to merge 1 commit into
Open
fix(abi): dynamic_cast error on Predicate across shared libraries#450zhangweilst wants to merge 1 commit into
zhangweilst wants to merge 1 commit into
Conversation
|
|
zhangweilst
force-pushed
the
predicate-abi
branch
2 times, most recently
from
July 24, 2026 10:21
f0d296c to
2154aa0
Compare
zjw1111
reviewed
Jul 24, 2026
zjw1111
left a comment
zjw1111
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix and for the thorough regression test that guards the key-function anchoring at the symbol level.
zhangweilst
force-pushed
the
predicate-abi
branch
from
July 27, 2026 06:23
2154aa0 to
3700cdd
Compare
zhangweilst
force-pushed
the
predicate-abi
branch
from
July 27, 2026 06:34
3700cdd to
b3dded5
Compare
Collaborator
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #449
Tests
Added predicate_abi_inte_test
API and Format
No
Documentation
No
Generative AI tooling