-
Notifications
You must be signed in to change notification settings - Fork 56
fix: nested list schema evolution #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XiaoHongbo-Hope
wants to merge
21
commits into
alibaba:main
Choose a base branch
from
XiaoHongbo-Hope:fix_nested_list_schema_evolution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
de10aa5
Support schema-evolution added fields inside list/map in PruneDataType
XiaoHongbo-Hope 0d00149
Null-fill nested added fields in data-evolution reader assembly
XiaoHongbo-Hope d0ed347
Reshape exist arrays for nested evolution in single-file reader path
XiaoHongbo-Hope 9d50b65
Add array-level test for AlignArrayToReadType nested null-fill
XiaoHongbo-Hope bf772a8
Add end-to-end test: read list<struct> file with an evolution-added i…
XiaoHongbo-Hope 83ee0e2
Trim comments
XiaoHongbo-Hope 48c30b9
Address review comments on PR #446
XiaoHongbo-Hope b565f23
Merge branch 'main' into fix_nested_list_schema_evolution
lxy-9602 113adb1
Handle dictionary-encoded nested leaves from ORC lazy decoding
XiaoHongbo-Hope 9dc15e3
Fix field-ID-blind equality and nested rename; clang-format
XiaoHongbo-Hope 9492011
Address review: drop redundant DE-reader alignment; JSON dict test
XiaoHongbo-Hope 1740dd5
Add list/map schema-evolution inte test; match nested fields by name
XiaoHongbo-Hope 55b47dc
Cast leaves to the read type and compare nested nullability
XiaoHongbo-Hope ee14e41
Trim comment
XiaoHongbo-Hope b8ad679
Update expected message for map value type-change rejection
XiaoHongbo-Hope 00131a8
Restrict AlignArrayToReadType leaf cast to representation-only changes
XiaoHongbo-Hope 0ffc476
Only normalize large_string in leaf representation check, not large_b…
XiaoHongbo-Hope 2b78370
Merge branch 'main' into fix_nested_list_schema_evolution
lxy-9602 0b85137
Merge branch 'main' into fix_nested_list_schema_evolution
lxy-9602 2e70b7d
Add nested large_binary blob alignment test
XiaoHongbo-Hope def0fee
Merge branch 'main' into fix_nested_list_schema_evolution
lxy-9602 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question I still have: if each file is already aligned via
AlignArrayToReadTypeinfield_mapping_reader.cpp, why do we need to do the same thing again indata_evolution_file_reader.cpp?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, updated.