refactor(toolbar): show attribute suggestions as a combobox instead of a datalist#62
Open
sarahdayan wants to merge 1 commit intomainfrom
Open
refactor(toolbar): show attribute suggestions as a combobox instead of a datalist#62sarahdayan wants to merge 1 commit intomainfrom
sarahdayan wants to merge 1 commit intomainfrom
Conversation
…ibute suggestions Extract a reusable Combobox primitive with keyboard navigation and ARIA attributes, and use it in ItemTemplateField instead of the native datalist. Remove the now-unused `list` prop from TextField. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for algolia-experiences-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sarahdayan
changed the title
✅ Deploy Preview for algolia-experiences-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item template fields suggest index attributes so the user doesn't have to type them from memory. Until now, suggestions used a native
<datalist>, which varies across browsers, can't be keyboard-navigated reliably, and doesn't filter as you type in all environments.This PR replaces the datalist with a proper combobox dropdown:
role="combobox",role="listbox",aria-activedescendantfor screen readersThe combobox logic is extracted into a reusable
Comboboxprimitive (ui/combobox.tsx) so PRs #60 and #61 can adopt it forAttributeFieldandAgentIdFieldinstead of duplicating the same dropdown behavior.