feat(ast,parser): round-trip ClickHouse SAMPLE and ORDER BY WITH FILL - #534
Open
basili4-1982 wants to merge 1 commit into
Open
feat(ast,parser): round-trip ClickHouse SAMPLE and ORDER BY WITH FILL#534basili4-1982 wants to merge 1 commit into
basili4-1982 wants to merge 1 commit into
Conversation
- SampleClause: renders SAMPLE [N/D] [OFFSET M/K] after FROM/ARRAY JOIN. - WithFillClause (From/To/Step) modeled on OrderByExpression; parser captures it instead of skipping; orderBySQL renders WITH FILL ... back. - Regression tests for SAMPLE (ratio/frac/offset) and WITH FILL (step/full/desc).
|
@basili4-1982 is attempting to deploy a commit to the coolajitpratapsingh0-9932's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouse
SAMPLEandORDER BY … WITH FILLare parsed but dropped on render(they do not round-trip), silently losing query semantics. This PR models both and
makes them round-trip.
Root cause
SampleClauseexisted onSelectStatementbut had noSQL()render → SAMPLE lost.ORDER BY … WITH FILL FROM x TO y STEP zwas skipped by the parser(
skipClickHouseWithFillTail) and not stored.Changes
pkg/sql/ast/ast_clauses.go: newWithFillClause(From/To/Step); addedOrderByExpression.WithFill *WithFillClause.pkg/sql/parser/select_clauses.go: ClickHouseWITH FILLtail is now parsed intoWithFillClauseinstead of being skipped.pkg/sql/ast/sql.go:SampleClause.SQL()rendersSAMPLE N[/D] [OFFSET M[/K]];SelectStatement.SQL()emitsSAMPLEafterARRAY JOIN/beforePREWHERE;orderBySQL()/withFillSQL()renderWITH FILL [FROM x] [TO y] [STEP z].pkg/sql/parser/clickhouse_sample_withfill_test.go: regression round-trip tests.Test plan
TestClickHouseSampleAndWithFillRoundtrip(sample ratio/fraction/offset,with-fill step/full/desc) — all green
go test -short ./pkg/sql/ast/ ./pkg/sql/parser/ ./pkg/gosqlx/ ./pkg/formatter/green