Repository navigation
docs: simplify low-code component schema descriptions - #1272
Draft
Ian Alton (ian-at-airbyte) wants to merge 1 commit into
Draft
Ian Alton (ian-at-airbyte) wants to merge 1 commit into
Ian Alton (ian-at-airbyte) wants to merge 1 commit into
Conversation
Co-Authored-By: ian.alton@airbyte.io <ian.alton@airbyte.io>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1794082119-plain-yaml-reference-descriptions#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1794082119-plain-yaml-reference-descriptionsPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites
descriptionstrings indeclarative_component_schema.yamlin plain language (targeting an 8th-grade reading level). These strings render into the low-code YAML reference on docs.airbyte.com, for example ApiKeyAuthenticator:Requested by Ian Alton.
HttpRequester.request_headers: auth headers don't overwrite yours.combine_mappingsraises on a duplicate key.RemoveFields.condition: "empty" meant the condition is unset. When it's unset, every field infield_pointersis removed.RecordSelector.schema_normalization,AsyncRetriever.abort_requesterandOAuthAuthenticator.profile_assertion: rewritten to match what the code does.models/declarative_component_schema.pyis regenerated, but only description strings change. The generator's unrelated type and ordering changes were dropped, and an AST comparison confirms no other change.No behavior changes.
Test plan
poetry run ruff format --check .andpoetry run ruff check .pass.poetry run pytest unit_tests/sources/declarative -x -q: 2593 passed, 1 skipped.Posted by Devin, on behalf of Ian Alton.
Open in Devin Desktop: https://app.devin.ai/desktop/session/f6027708863547fcadfe500518752e81?variant=devin