Skip to content

ci: split the Slack PR daily digest into needs-review and approved-or-merged sections - #1263

Merged
Patrick Nilan (pnilan) merged 2 commits into
mainfrom
devin/1793743589-slack-digest-merged-section
Nov 3, 2026
Merged

Patrick Nilan (pnilan) merged 2 commits into
mainfrom
devin/1793743589-slack-digest-merged-section

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #1262. The first dry run said "No PRs became ready for review in the last 24 hours" even though #1260 and #1261 were opened that day. Both were already merged, and the digest only listed PRs that were still open. The digest now has two sections:

  • Needs review (:new_pr:): opened as non-draft or marked ready in the window, still open and non-draft, and reviewDecision != APPROVED. The <!subteam^S077U1TH43D> mention appears only when this section isn't empty.
  • Approved or merged: PRs from the ready set that are now APPROVED (:white_check_mark:), plus PRs merged in the window based on mergedAt (:merged:). Merged PRs that were marked ready before the window are included.

One GraphQL call with two aliased searches that share the prFields fragment, which now includes reviewDecision:

ready:  repo:… is:pr is:open draft:false updated:>=<start>   → filter readyAt >= start → split by reviewDecision
merged: repo:… is:pr is:merged merged:>=<start>              → filter mergedAt >= start

A null reviewDecision is treated as needing review. PRs closed without merging are still not listed. The header is now *PR Daily Summary*.

Output from running the steps locally against today's live data (24h window):

:mag: *PR Daily Summary* in `airbytehq/airbyte-python-cdk`
Tuesday, November 3, 2026 at 2:20 PM PT
No PRs marked ready for review in the last 24 hours still need review.

*Approved or merged:* 5 PRs in the last 24 hours:
• :white_check_mark: <…/pull/1263|#1263> ci: add a merged-PRs section to the Slack PR daily digest — by <…|devin-ai-integration>  ·  …
• :merged: <…/pull/1257|#1257> fix(concurrent-cursor): don't advance parent state past unyielded child slices when parent generation fails — by <…|ZaneHyattAB>  ·  …
• :merged: <…/pull/1261|#1261> ci: pin Pytest matrix runner to `ubuntu-24.04` — by <…|devin-ai-integration>  ·  …
• :merged: <…/pull/1260|#1260> fix(deps): lock `Pillow` 13.0.0 on Python 3.11+ to remediate CVEs — by <…|devin-ai-integration>  ·  …
• :merged: <…/pull/1262|#1262> ci: replace per-PR #team-apis Slack post with a weekday ready-for-review digest — by <…|devin-ai-integration>  ·  …

With a widened window, the needs-review header renders as <!subteam^…> *1 PR* marked ready for review in the last 24 hours still needs review: followed by • :new_pr: <…|#1246> ….

actionlint and prettier --check pass.

Link to Devin session: https://app.devin.ai/sessions/e378de9fd9d949439935a901d2158595
Open in Devin Desktop: https://app.devin.ai/desktop/session/e378de9fd9d949439935a901d2158595?variant=devin

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1793743589-slack-digest-merged-section#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1793743589-slack-digest-merged-section

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@pnilan
Patrick Nilan (pnilan) marked this pull request as ready for review November 3, 2026 22:11
@pnilan
Patrick Nilan (pnilan) requested a review from a team as a code owner November 3, 2026 22:11
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

PyTest Results (Fast)

6 306 tests  ±0   6 285 ✅ ±0   7m 5s ⏱️ +9s
    1 suites ±0      21 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 7309a14. ± Comparison against base commit aebf73c.

♻️ This comment has been updated with latest results.

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@devin-ai-integration devin-ai-integration Bot changed the title ci: add a merged-PRs section to the Slack PR daily digest ci: split the Slack PR daily digest into needs-review and approved-or-merged sections Nov 3, 2026
@pnilan
Patrick Nilan (pnilan) merged commit e97f461 into main Nov 3, 2026
22 checks passed
@pnilan
Patrick Nilan (pnilan) deleted the devin/1793743589-slack-digest-merged-section branch November 3, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant