Repository navigation
ci: split the Slack PR daily digest into needs-review and approved-or-merged sections - #1263
Merged
Patrick Nilan (pnilan) merged 2 commits intoNov 3, 2026
Conversation
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1793743589-slack-digest-merged-section#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1793743589-slack-digest-merged-sectionPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Patrick Nilan (pnilan)
approved these changes
Nov 3, 2026
Patrick Nilan (pnilan)
marked this pull request as ready for review
November 3, 2026 22:11
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Patrick Nilan (pnilan)
deleted the
devin/1793743589-slack-digest-merged-section
branch
November 3, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1262. The first dry run said "No PRs became ready for review in the last 24 hours" even though #1260 and #1261 were opened that day. Both were already merged, and the digest only listed PRs that were still open. The digest now has two sections:
:new_pr:): opened as non-draft or marked ready in the window, still open and non-draft, andreviewDecision != APPROVED. The<!subteam^S077U1TH43D>mention appears only when this section isn't empty.APPROVED(:white_check_mark:), plus PRs merged in the window based onmergedAt(:merged:). Merged PRs that were marked ready before the window are included.One GraphQL call with two aliased searches that share the
prFieldsfragment, which now includesreviewDecision:A
nullreviewDecisionis treated as needing review. PRs closed without merging are still not listed. The header is now*PR Daily Summary*.Output from running the steps locally against today's live data (24h window):
With a widened window, the needs-review header renders as
<!subteam^…> *1 PR* marked ready for review in the last 24 hours still needs review:followed by• :new_pr: <…|#1246> ….actionlintandprettier --checkpass.Link to Devin session: https://app.devin.ai/sessions/e378de9fd9d949439935a901d2158595
Open in Devin Desktop: https://app.devin.ai/desktop/session/e378de9fd9d949439935a901d2158595?variant=devin