Repository navigation
do-not-merge: fix(file-based): satisfy Form UX checks in shared file-based spec - #1258
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1793391678-form-ux-file-based-spec#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1793391678-form-ux-file-based-specPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This was referenced Oct 30, 2026
Draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge. This is a demo PR. It shows what the shared file-based spec needs in order to pass the proposed Form UX checks (
UX-01–UX-12) from airbyte-ops-mcp#1531, which are defined by the handbook rewrite in airbyte#89600. Requested by Aaron ("AJ") Steers (@aaronsteers).Summary
Most Form UX findings on file-based sources come from fields the CDK owns, not the connector:
start_date,delivery_method,streams[]and the format options. This PR fixes them inairbyte_cdk/sources/file_based/config/*. #1531 only gates manifest-only connectors, so the sameFormUxCheck.find()rules were run directly against each connector's emittedspec.Results with this branch installed (CDK
7.43.0.post3.dev0+a62f297e), alongside the connector PRs:mastersource-google-drivesource-s3Delivery Methodtitle override, fixed in the connector PR)Connector PRs: airbyte#90265 (
source-google-drive), airbyte#90266 (source-s3).Commits:
dd6a800b: non-breaking changes. Sentence-case titles (UX-02) and more specific descriptions (UX-08), e.g. CSVdouble_quote,skip_rows_after_header,true_values/false_values. It also fixes the typo'd titleFiles To Read For Schema Discover→Files to read for schema discovery.a62f297e: UX-07, breaking.AbstractFileBasedSpec.schema()now adds every visible defaulted property torequired, recursively throughdelivery_method,streams[].itemsand theoneOfoptions. Hidden properties are skipped.delivery_methodnow spell out its schema default. That count shows the blast radius: any existing config that leaves out a now-required field fails spec validation. The inline expected spec incsv_scenarios.pymoved tofile_based_spec.json.Form preview, using
source-google-drivewith this branch and the connector PR (airbyte#90265). Collapsed sections are force-expanded. Stream-level fields are in the "Add stream" modal, so they aren't shown here.Verification: the narrow config tests and the file-based scenario suite (
253 passed) both pass, and Ruff is clean.Posted by Devin, on behalf of Aaron ("AJ") Steers (@aaronsteers).
Open in Devin Desktop: https://app.devin.ai/desktop/session/b3e2eb2e3fdd47ca9141ad358b23a988?variant=devin