Open
Conversation
Author
|
Giving it a try @ljharb 🙏 |
This comment was marked as resolved.
This comment was marked as resolved.
ljharb
requested changes
Mar 25, 2026
| "eslint": "^7.32.0 || ^8.2.0", | ||
| "eslint-find-rules": "^4.1.0", | ||
| "eslint": "^7.32.0 || ^8.2.0 || ^9.0.0", | ||
| "eslint-find-rules": "^5.0.0", |
Collaborator
There was a problem hiding this comment.
eslint-find-rules v5 doesn't support eslint 7, so this will have to be ^4.1.0 || ^5.0.0
| "dependencies": { | ||
| "confusing-browser-globals": "^1.0.11" | ||
| "confusing-browser-globals": "^1.0.11", | ||
| "globals": "^15.14.0" |
Collaborator
There was a problem hiding this comment.
why is globals needed? eslint ships with that package and we should be using the same version it uses.
Author
There was a problem hiding this comment.
@ljharb without it being in the package.json we fail the no extraneous dependencies check due to the import. So I put it as a peer dependency. Otherwise I could either disable the rule or use the raw values instead of from globals. Let me know if you want a different change
| "eslint": "^7.32.0 || ^8.2.0", | ||
| "eslint-find-rules": "^4.1.0", | ||
| "eslint": "^7.32.0 || ^8.2.0 || ^9.0.0", | ||
| "eslint-find-rules": "^5.0.0", |
Author
|
@ljharb let me know your thoughts with the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giving my attempt at eslint 9 support 😅