Skip to content

refactor: drop the defmt mirrors the log macros now cover (#352, 3/3) #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lxsaah merged 1 commit into from
Oct 24, 2026
Merged

refactor: drop the defmt mirrors the log macros now cover (#352, 3/3) #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions aimdb-core/src/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,6 @@ impl Router {
}
Err(_e) => {
log_warn!("Failed to ingest message on '{}': {}", resource_id, _e);

#[cfg(feature = "defmt")]
defmt::warn!(
"Failed to ingest message on '{}': {}",
resource_id,
_e.as_str()
);
}
}
}
Expand All @@ -172,14 +165,8 @@ impl Router {
"Route matched for '{}' but message was not produced (ingest errors)",
resource_id
);

#[cfg(feature = "defmt")]
defmt::debug!("Route matched for '{}' but not produced", resource_id);
} else {
log_debug!("No route found for resource: '{}'", resource_id);

#[cfg(feature = "defmt")]
defmt::debug!("No route found for resource: '{}'", resource_id);
}
}

Expand Down
7 changes: 0 additions & 7 deletions aimdb-core/src/session/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,13 +927,6 @@ async fn inbound_pump(handle: ClientHandle, inbound: crate::InboundDispatch, id:
id.as_ref(),
update.skipped
);

#[cfg(feature = "defmt")]
defmt::warn!(
"mirror gap on '{}': {} update(s) lost (latest-state, no resync)",
id.as_ref(),
update.skipped
);
}
inbound.dispatch(id.as_ref(), &update.data);
}
Expand Down
10 changes: 0 additions & 10 deletions aimdb-mqtt-connector/src/embedded/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,6 @@ fn inbound_topics(
"MQTT: inbound route '{}' asks for qos=2; this backend subscribes at QoS 1 (at-least-once). The std backend honours qos=2 on the same URL.",
route.topic
);
#[cfg(feature = "defmt")]
defmt::warn!(
"MQTT: inbound route '{}' asks qos=2; subscribing at QoS 1 (at-least-once)",
&*route.topic
);
}
}

Expand Down Expand Up @@ -227,11 +222,6 @@ fn prepare_outbound(
"MQTT: route '{}' asks for qos=2; this backend publishes it at QoS 1 (at-least-once). The std backend honours qos=2 on the same URL.",
route.default_topic
);
#[cfg(feature = "defmt")]
defmt::warn!(
"MQTT: route '{}' asks qos=2; publishing at QoS 1 (at-least-once)",
&*route.default_topic
);
}
opts.push(opt);
}
Expand Down
11 changes: 0 additions & 11 deletions aimdb-mqtt-connector/src/embedded/session_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,17 +456,6 @@ async fn publish_staged(
"write ring's"
}
);
#[cfg(feature = "defmt")]
defmt::warn!(
"MQTT: skipping publish to {}: {} bytes exceed the {} limit",
msg.topic,
len,
if over_broker {
"broker's"
} else {
"write ring's"
}
);
true
} else {
ring.put_sized(&packet, len, CONTROL_RESERVE).await?;
Expand Down