[AAASM-3415] 🔧 (native): Forward teamId/parentAgentId on native register#165
Conversation
Move the aa-sdk-client/aa-proto git-SHA pin to the agent-assembly AAASM-3415 branch tip, which adds team_id/parent_agent_id to AssemblyConfig. Move to the squash-merge commit once PR #1160 lands. refs AAASM-3415 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
RegisterOptions gains team_id/parent_agent_id and register() sets them on AssemblyConfig so the native gRPC Register carries the agent's team-budget scoping and topology lineage (AAASM-3415). Regenerated index.d.ts. refs AAASM-3415 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
RegisterOptions (TS) gains teamId/parentAgentId and buildRegisterOptions sets each when present, so initAssembly's team/parent config reaches the native register and the gateway gets team scoping + topology (AAASM-3415). refs AAASM-3415 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add initAssembly forwarding tests: teamId/parentAgentId reach the native register when set, and are omitted when unconfigured (AAASM-3415). refs AAASM-3415 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Chisanan232
left a comment
There was a problem hiding this comment.
Claude Code — PR review (AAASM-3415, node-sdk)
Verdict: ✅ approve — but merge AFTER agent-assembly #1160 + re-pin. CI green (quality, pin-consistency, module-smoke, Analyze); only codecov/patch red (Rust-shim lines uncovered by JS tests — advisory, non-blocking).
- napi
RegisterOptions+ TSRegisterOptions/buildRegisterOptionsforwardteamId/parentAgentId;index.d.tsregenerated.pnpm test307 pass/2 skip (2 new); typecheck/lint/clippy clean. Kept the shim's 2-space style (minimal +11 diff; repo doesn't gate on rustfmt). ✅
aa-sdk-client/aa-proto to agent-assembly branch-tip 209572bc. After #1160 squash-merges, re-pin to the merge commit + re-push (pin-consistency gate will re-run), THEN merge. (I can handle the re-pin once #1160 is in.)
…8e40) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…trip cases Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Chisanan232
left a comment
There was a problem hiding this comment.
Claude Code — re-pin + test pass (AAASM-3415, node)
✅ Re-pin clean + coverage strengthened — merge-ready. Re-pinned aa-sdk-client/aa-proto → merged fdff8e40; aa-* crates share one git rev (pin-consistency) green; all 3 agent-assembly git deps on the single rev. pnpm native:build rebuilt with no index.d.ts drift.
New tests/register-lineage-forwarding.test.ts (7 tests) covers: full config→RegisterOptions exact shape; only-teamId (parent omitted); only-parentAgentId (team omitted); neither; unicode round-trip; long-value no-truncation; empty-string teamId treated as unset — all via the public initAssembly path. Suite 314 pass / 2 skip; typecheck + lint clean. Only codecov/patch red (advisory). Good to merge.



Target
Task summary:
When the Node SDK moved to native gRPC
Register(Epic AAASM-3395 / AAASM-3403), the native register path stopped forwarding the lineage/team fields the old REST register sent.teamIddrives team-budget attribution;parentAgentIddrives the topology graph. This restores forwarding over the native path.Task tickets:
aa-ffi-golineage forwarding — deferred follow-up (go-sdk is being edited concurrently by AAASM-3404).Closes AAASM-3415)Key point change:
native/aa-ffi-nodeRegisterOptionsgainsteam_id/parent_agent_id;registersets them on theaa-sdk-clientAssemblyConfig.index.d.tsregenerated.RegisterOptionsgainsteamId/parentAgentId;buildRegisterOptionssets each only when present so an unset field stays absent.AssemblyConfig(TS) already exposedteamId/parentAgentId; this wires them through to register.aa-sdk-client/aa-protogit-SHA pin to the agent-assembly AAASM-3415 commit that adds theAssemblyConfigfields. No proto change was needed (the wire already carries both fields).Effecting Scope
Action Types:
Scopes:
Additional description:
pnpm native:build(against the new pin) ·pnpm typecheck·pnpm native:check-types·pnpm lint·pnpm test→ 307 passed / 2 skipped (incl. 2 new forwarding tests intests/native-register.test.ts).cargo clippy --all-targets -- -D warningson the shim clean. The shim's 2-space style is preserved (the diff is a minimal +11 lines —cargo fmt's default 4-space reformat was not applied as the repo has norustfmt.tomland CI does not gate on it).Description
None/ omitted leaves the agent team-unscoped / root, preserving current behaviour.209572bc…); move it to the squash-merge commit once PR #1160 merges. Not hard-blocked since no proto change was needed.🤖 Generated with Claude Code