PROD-2312: reserve ✗ glyph for real failures, use ○ for benign skips#181
Merged
Conversation
…ilure glyph The push/sync per-line log used the red ✗ failure glyph for several benign skips, making runs look catastrophically broken even though the phase summary already counted them correctly as skips. These call sites increment the skip counter (or record a preflight action: "skip") but logged via logger.<entity>.error(...), which maps to the failed/✗ glyph. Switch them to logger.<entity>.skipped(...) so they render the yellow ○ skip glyph. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jules-exel
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The push/sync per-line log emitted the red ✗ failure glyph for several benign skips, making runs look catastrophically broken. The glyph is chosen by log status in `src/core/logs.ts` (`failed` → red ✗, `skipped` → yellow ○), and the `.error(...)` vs `.skipped(...)` logger helpers map to those statuses. A handful of skip paths incremented the skip counter (or recorded a preflight `action: "skip"`) but logged via `logger..error(...)`, so the per-line glyph disagreed with the actual outcome.
The phase-summary counts were already correct — these paths already did `skipped++` / recorded `action: "skip"`. This change only fixes the per-line glyph; no counts change.
Call sites changed
Left unchanged (genuine failures / conflicts, verified)
Reviewed every `logger..error(...)` call under `src/lib/pushers/**`. All remaining ones are real failures (catch blocks with `failed++`, `throw`, or `return { status: "failure" }`), or conflicts recorded as `action: "conflict"` (e.g. container/gallery/asset "target changed; use --overwrite"). One change-detection catch logs an error but still processes the item, so it is not a skip. These were intentionally not touched.
Testing
`npm run type-check` passes. No new unit test added: the status→glyph mapping is covered by `src/core/tests/logs.test.ts` and the skip-count paths by existing pusher tests; reproducing the deleted-target-mapping branch would require non-trivial ContainerMapper filesystem setup for little added coverage.
🤖 Generated with Claude Code