fix PostgreSQL upsert SQL syntax error (#2166)#2167
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR fixes a clear PostgreSQL syntax error in PostgresBaseStore.UPSERT_SQL where an extra comma (,,) appeared at the end of the version assignment inside the ON CONFLICT DO UPDATE SET clause. The double comma would cause every put() call to fail with a SQL parse error at runtime, making the upsert path completely non-functional. The fix is a minimal one-character removal that is correct and complete. No secondary issues or missing test coverage concerns rise to the level of a finding given the triviality and precision of the change.
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR fixes a clear PostgreSQL syntax error in PostgresBaseStore.UPSERT_SQL where an extra comma (,,) appeared at the end of the version assignment inside the ON CONFLICT DO UPDATE SET clause. The double comma would cause every put() call to fail with a SQL parse error at runtime, making the upsert path completely non-functional. The fix is a minimal one-character removal that is correct and complete. No secondary issues or missing test coverage concerns rise to the level of a finding given the triviality and precision of the change.
Fixes #2166.
Removed an extra comma in
PostgresBaseStore.UPSERT_SQLthat caused a PostgreSQL syntax error on theON CONFLICT ... DO UPDATEbranch.