fix(harness): persist evicted tool results remotely#2150
Conversation
|
u010143241 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR fixes issue #2145 where tool-result eviction artifacts failed to persist through remote filesystem. Two root causes are addressed: (1) DEFAULT_EVICTION_PATH was an absolute path /large_tool_results that couldn't be matched by RemoteFilesystemSpec routing (which uses non-slash-prefixed prefix keys); (2) eviction replacements only applied to AgentState.contextMutable(), missing the call-scoped ReasoningInput.inputMessages(), causing the current inference to still use the original large content. The fix is clean: workspace-relative paths, routing table registration, and dual replacement logic. The changes are focused and well-scoped.
(inline comments could not be attached — line numbers fell outside PR hunks. See archived report.)
Summary:
Fixes #2145
Verification: 37 focused Harness/RemoteFilesystem/eviction tests passed; real Redis strict writer and fresh reader each passed in JCode; Spotless and git diff check passed.