fix(harness): drain session mirrors on close#2149
Conversation
|
u010143241 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
Adds deterministic FIFO barrier (awaitPendingMirrors) to SessionTree for draining pending async mirror operations before HarnessAgent.close(). Correct shutdown ordering, proper interrupt handling, good test coverage replacing unreliable Thread.sleep waits. No issues found.
|
Please sign the CLA at: https://cla-assistant.io/agentscope-ai/agentscope-java?pullRequest=2149 Code Review (pending CLA)Summary: Adds deterministic FIFO barrier for SessionTree mirror work submitted before shutdown. Findings:
Verdict: Important fix for distributed store reliability. Ready to merge once CLA is signed. Automated review by github-manager |
Summary:
Fixes #2147
Verification: 41 focused Harness/session/memory tests passed; Spotless and git diff check passed.