fix(shell-execute): optimize working_directory parameter and tool usage hints#2107
Open
chcodex wants to merge 3 commits into
Open
fix(shell-execute): optimize working_directory parameter and tool usage hints#2107chcodex wants to merge 3 commits into
chcodex wants to merge 3 commits into
Conversation
…arameter, marking it as non-required
… read_file, write_file) exist, special tools should be used in preference to shell commands
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
oss-maintainer
approved these changes
Jul 11, 2026
oss-maintainer
left a comment
oss-maintainer
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Trivial change, looks good.
Automated review by github-manager-bot
AgentScopeJavaBot
added
bug
AgentScopeJavaBot
left a comment
AgentScopeJavaBot
left a comment
Collaborator
There was a problem hiding this comment.
🤖 AI Review
Optimizes ShellExecuteTool working_directory parameter and adds LLM usage hints. Small focused change. Suggestion: make timeout also optional for consistency.
(inline comments could not be attached — line numbers fell outside PR hunks. See archived report.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
Based on upstream/main
Description
Three optimizations for ShellExecuteTool:
working_directoryparameter as non-required (required = false)workingDirectoryparameter descriptionHow to Test
working_directoryparameter is non-requiredChecklist
mvn spotless:applymvn test)