feat(browser): support custom Chromium binaries with isolated profiles - #462
Merged
Conversation
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
rishabhraj36
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
WEBCMD_BROWSER_BINARY_PATHenvironment override for compatible Chromium executables. The Webcmd-owned variable takes precedence over the existingCLOAKBROWSER_BINARY_PATH, while managed Cloak remains the unchanged default when neither is set.The override is forwarded to persistent Playwright launches and mirrored into CloakBrowser configuration so managed binary resolution and downloads are skipped. On macOS, custom executables use the normal Playwright persistent launcher because third-party app bundles may not implement the managed browser background-CDP contract. Doctor validates and reports the effective override.
Custom browsers now receive isolated profile directories under
~/.webcmd/<browser>/profiles. Known ChromiumFish and Clark paths resolve to stable namespaces, named application bundles such as Brave and Google Chrome use their application name, and unknown Chromium executables use a deterministic path-derived namespace. Managed Cloak continues using~/.webcmd/cloak/profiles.Related issue: none
Type of Change
Checklist
Verification
origin/mainnpm run typecheck: passednpm run build: passed before the latest upstream merge~/.webcmd/google-chrome/profiles/default26e4c008-a81a-406c-941f-166d21e115a3: no blocking findingsThe earlier full unit/plugin suite passed 6,278 tests and had five unrelated existing DNS-policy failures in
src/fetch/safe-proxy.test.tsunder local Node 26.7.0.