feat(evaluators): new api from runners-api#242
Open
namrataghadi-galileo wants to merge 8 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v1/scorers/invoke.GALILEO_API_SECRET_KEYorGALILEO_API_SECRET.scorer_idthe required runtime identity;scorer_labelis optional metadata andscorer_version_idis optional pinning.config: {}and never forwardGalileo-API-Keyto runners-api.Scope
User-facing/API changes:
scorer_id; label-only and version-only configs are rejected.GALILEO_RUNNERS_API_URL,GALILEO_LUNA_SCORER_ID, and internal secret auth.Internal changes:
/scorers/invokeand/internal/scorers/invokeclient routing with runners-api routing.Out of scope:
Risk and Rollout
scorer_id, migrate those controls or temporarily roll back before retrying cutover.Testing
make check(targeted package validation was run instead)Targeted validation:
make -C evaluators/contrib/galileo test-> 86 passedmake -C evaluators/contrib/galileo lint-> passedmake -C evaluators/contrib/galileo typecheck-> passedgit diff --check-> cleanChecklist
scorer_id