Skip to content

fix: use executable model names for turns - #428

Open
Excelius-Wang wants to merge 1 commit into
agentclientprotocol:mainfrom
Excelius-Wang:fix/use-executable-model-name
Open

fix: use executable model names for turns#428
Excelius-Wang wants to merge 1 commit into
agentclientprotocol:mainfrom
Excelius-Wang:fix/use-executable-model-name

Conversation

@Excelius-Wang

Copy link
Copy Markdown

Summary

  • resolve ACP catalog IDs to their executable Codex model names before starting a turn
  • preserve uncatalogued custom-provider model IDs as a fallback
  • add regression coverage for catalogs where Model.id differs from Model.model

Testing

  • npm test
  • npm run typecheck
  • npm run build
  • git diff --check

Fixes #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codex-acp sends Model.id to turn/start instead of executable Model.model

1 participant