fix: use session cwd when listing skills#251
Open
LucaDiba wants to merge 1 commit into
Open
Conversation
Use the active ACP session roots when publishing skill commands and handling /skills so Codex app-server does not fall back to the adapter process cwd. Adds a portable e2e regression for repo-local skills under the session workspace. Fixes agentclientprotocol#250
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes skill discovery for ACP sessions whose
cwddiffers from thecodex-acpprocess cwd.Previously, session startup refreshed skills with the correct session cwd, but available command publication and
/skillslater calledskills/listwith no params. Codex app-server then defaulted back to the adapter process cwd, so repo-local skills from the active ACP session workspace were missing and unrelated repo skills could appear instead.This changes command skill listing to pass the active session roots:
sessionState.cwdsessionState.additionalDirectoriesFixes #250
Changes
SessionStateinto available command publication.skills/listparams for:available_commands_update/skills.agents/skillsand verifies:$workspace-skillappears in available commands/skillslistsworkspace-skilllistSkillswith the session cwd and additional directories.Verification
npm run typechecknpm run test