Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/CodexAcpClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import type {
SkillsListResponse,
SandboxPolicy,
Thread,
ThreadGoalStatus,
ThreadSourceKind,
TurnCompletedNotification,
UserInput,
Expand Down Expand Up @@ -329,6 +330,39 @@ export class CodexAcpClient {
await this.codexClient.runCompact({threadId: sessionId});
}

async setGoal(
sessionId: string,
objective: string,
onTurnStarted?: (turnId: string) => void,
): Promise<TurnCompletedNotification | null> {
return await this.codexClient.runGoalSet({
threadId: sessionId,
objective,
status: "active",
}, onTurnStarted);
}

async setGoalStatus(sessionId: string, status: ThreadGoalStatus): Promise<void> {
await this.codexClient.runGoalSet({
threadId: sessionId,
status,
});
}

async resumeGoal(
sessionId: string,
onTurnStarted?: (turnId: string) => void,
): Promise<TurnCompletedNotification | null> {
return await this.codexClient.runGoalSet({
threadId: sessionId,
status: "active",
}, onTurnStarted);
}

async clearGoal(sessionId: string): Promise<void> {
await this.codexClient.runGoalClear({threadId: sessionId});
}

async awaitMcpServerStartup(serverNames: Array<string>, afterVersion: number): Promise<McpStartupResult> {
return await this.codexClient.awaitMcpServerStartup(serverNames, afterVersion);
}
Expand Down
27 changes: 23 additions & 4 deletions src/CodexAcpServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type {
ReasoningEffortOption,
Thread,
ThreadItem,
TurnCompletedNotification,
UserInput
} from "./app-server/v2";
import type {RateLimitsMap} from "./RateLimitsMap";
Expand Down Expand Up @@ -66,6 +67,12 @@ import packageJson from "../package.json";
import {isJetBrains2026_1Client} from "./JBUtils";
import {resolveTerminalOutputMode, type TerminalOutputMode} from "./TerminalOutputMode";

export interface ThreadGoalSnapshot {
objective: string;
status: string;
tokenBudget: number | null;
}

export interface SessionState {
sessionId: string,
currentModelId: string,
Expand All @@ -87,6 +94,7 @@ export interface SessionState {
currentModelSupportsFast: boolean;
sessionMcpServers?: Array<string>;
terminalOutputMode: TerminalOutputMode;
currentGoal?: ThreadGoalSnapshot | null;
}

interface ActiveAuthState {
Expand Down Expand Up @@ -1389,6 +1397,13 @@ export class CodexAcpServer {
sessionState.lastTokenUsage = null;
const activePrompt = this.trackActivePrompt(params.sessionId);
let pendingTurnStart: PendingTurnStart | null = null;
const ensurePendingTurnStart = (): PendingTurnStart => {
if (pendingTurnStart === null) {
pendingTurnStart = this.createPendingTurnStart();
this.pendingTurnStarts.set(params.sessionId, pendingTurnStart);
}
return pendingTurnStart;
};
const disposePromptRequestCancellation = this.observePromptRequestCancellation(signal, sessionState, activePrompt);

try {
Expand All @@ -1408,6 +1423,9 @@ export class CodexAcpServer {
}

const commandPromise = this.availableCommands.tryHandleCommand(params.prompt, sessionState, {
onTurnStartPending: () => {
ensurePendingTurnStart();
},
onTurnStarted: (turnId, threadId) => {
const turn = {threadId, turnId};
activePrompt.currentTurn = turn;
Expand All @@ -1416,6 +1434,7 @@ export class CodexAcpServer {
return;
}
sessionState.currentTurnId = turnId;
pendingTurnStart?.resolve(turnId);
},
});
void commandPromise.catch((err) => {
Expand Down Expand Up @@ -1474,8 +1493,7 @@ export class CodexAcpServer {
sessionState.fastModeEnabled,
sessionState.currentModelSupportsFast,
);
pendingTurnStart = this.createPendingTurnStart();
this.pendingTurnStarts.set(params.sessionId, pendingTurnStart);
ensurePendingTurnStart();
const sendPromptPromise = this.runWithProcessCheck(
() => this.codexAcpClient.sendPrompt(
params,
Expand Down Expand Up @@ -1537,10 +1555,11 @@ export class CodexAcpServer {
logger.log("Prompt completed", {sessionId: params.sessionId});
disposePromptRequestCancellation();
sessionState.currentTurnId = null;
if (pendingTurnStart !== null && this.pendingTurnStarts.get(params.sessionId) === pendingTurnStart) {
const registeredPendingTurnStart = this.pendingTurnStarts.get(params.sessionId);
if (registeredPendingTurnStart !== undefined) {
this.pendingTurnStarts.delete(params.sessionId);
registeredPendingTurnStart.resolve(null);
}
pendingTurnStart?.resolve(null);
activePrompt.complete();
}
}
Expand Down
Loading