feat: LLM-26878 Add “Fast” mode for Codex-agent#133
Open
NikolaiSviridov wants to merge 1 commit intomainfrom
Hidden character warning
The head ref may contain hidden characters: "nikolaisv/main/LLM-26878-Add-\u201cFast\u201d-mode-for-Codex-agent"
Open
feat: LLM-26878 Add “Fast” mode for Codex-agent#133NikolaiSviridov wants to merge 1 commit intomainfrom
NikolaiSviridov wants to merge 1 commit intomainfrom
Conversation
AlexandrSuhinin
requested changes
May 5, 2026
|
|
||
| static fromString(modelId: string): ModelId { | ||
| const bracketMatch = modelId.match(/^(?<model>[^\[]+?)(?:\[(?<effort>[^\]]+)\])?$/); | ||
| const bracketMatch = modelId.match(/^(?<model>[^\[]+)\[(?<effort>[^\]]+)](?:@(?<serviceTier>.+))?$/); |
Collaborator
There was a problem hiding this comment.
This is already too complicated. Especially we leak into the "protocol" codex-specific details.
I would rather expose this as a new model in the picker and would remap it internally into the same model with fast service. Though I'd avoid mapping based on the model id parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.