Add ring solver#39
Open
WhatisRT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a practical ring solver based on the machinery on the standard library. The focus here is on something that one should expect to work by default - to that end, there's over 100 tests on various abstract & concrete scenarios. There are two documented limitations (it doesn't help solving metas & it doesn't support subtraction) but other than that I'm not aware of any cases where you should expect a ring solver to work but this one doesn't.
There's also a comparison with reflective ring solvers that are part of the standard library in
Tactic.Solver.Ring.Tests.Comparison, demonstrating the various issues and that they are fixed with this solver.I intend to generalise this into a general purpose reflective solver harness in the future, but for now this seems useful enough to share.