Conversation
L'un des quick wins de la migration globale Ting vers Doctrine (afup#2383). Pattern : entité Doctrine déclarée, repository héritant d'EntityRepository, bascule des usages, suppression des classes Ting.
Korbeil
marked this pull request as ready for review
September 21, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migre la suggestion de conférencier·e (table
afup_speaker_suggestion) de Ting vers Doctrine. C'est l'un des quick wins de la migration globale Ting → Doctrine suivie dans #2383, en suivant le pattern de la PR #2387 : déclaration de l'entité Doctrine → repository Doctrine → bascule des usages → suppression des classes Ting.Changements
AppBundle\Event\Entity\SpeakerSuggestionmappée surafup_speaker_suggestion(propriétés fortement typées et publiques,commentnullable, dates enDateTimeImmutable)SpeakerSuggestionRepositoryhéritant deEntityRepository; le CRUD passe par l'EntityManager (aucun SQL brut)Comment tester
make test-integration-ci— suite d'intégration dont le nouveau test du repository (4 cas : save + id généré, relecture des champs, comment NULL, delete)make phpstan— analyse statique, 0 erreurmake test-functional— le scénario BehatSpeakerProposal.featurecouvre le parcours public de bout en bout (formulaire → sauvegarde → email)