Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec conformance hardening
Verifies every module against the aep-spec drafts and fixes what they
turned up. Where the Node SDK and the drafts disagreed, the drafts decided;
on several points Node and Java already agreed and this SDK was the outlier.
Headline fixes
create_did_documentcopied the key store's JWK verbatiminto a document served to anyone resolving the Agent DID, so one still
carrying
dpublished the signing key (PLT-DID-002).lifetime_secondsabove the configured maximum raised before authorization, so any caller
could reach it (PLT-SIGN-011).
urlsplitstrips CR/LF/tab before parsing, so a did:web hostwas validated sanitized and used raw, putting a carriage return in a URL
handed to an HTTP client;
render_authorizationemitted CR and LFverbatim; OpenAPI security inheritance (CORE-OAS-011/013/014/015) had no
implementation at all.
authentication_requiredinstead ofnot_recognized(CORE-PR-038);Basic credentials were issued that cannot survive RFC 7617 encoding
(BSC-RSP-003).
HEADwas unsupported whereGETwas, and unsupportedmethods answered 400 while already sending
Allow(RFC 9110 9.1, 15.5.5).The
agentpackage needed no fixes.The conformance harness could not fail. Nine agent mappings compared
two constants or two fields of the same vector; one asserted a hard-coded
set literal. They now drive the real Agent, Platform and Service.
tests/test_conformance_falsifiability.pyfeeds each vector twice — oncepublished, once with a corrupted expectation — and requires the result to
flip; it caught three mappings written for this PR.
Verification —
make verifygreen; 293 tests;