Enable gradual migration to protobuf v2 APIs #125
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavy lifting for migration to protobuf v2 APIs already done by @noahdietz and @quirogas - reusing the code as-is. Kudos. Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com> Co-authored-by: Santiago Quiroga <quirogas@users.noreply.github.com>
Aiming for a surgical change that runs the v1 and v2 linter engines in parallel during a transitional period where we gradually migrate all the v1 rules to the v2 APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit backports the v2 linter engine from https://github.com/googleapis/api-linter - intentionally no changes made.
Second commit incorporates the v2 linter engine to run alongside the existing v1 engine. Enabling gradual migration of linter rules from v1 to v2 in subsequent changes.
Trade-off of this approach (running v1 and v2 simultaneously) is increased processing cost from parsing all files twice (jhump/protoreflect and bufbuild/protocompile). Benefit is we can make minimal changes to the existing battle-tested v1 and v2 code during the migration.