Merged
Conversation
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
couple comments. main question to me is about whether we should better define how long an idempotency key is valid for?
toumorokoshi
approved these changes
Nov 29, 2023
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
I think my main nit at this point is about the guidance on a minimum (still don't see it).
Also I'd consider my comment on the formats accepted by idempotency key. But not going to block further.
gibson042
reviewed
Nov 30, 2023
rofrankel
commented
Dec 14, 2023
Collaborator
Author
rofrankel
left a comment
rofrankel
left a comment
There was a problem hiding this comment.
Replying with notes from yesterday's meeting.
toumorokoshi
pushed a commit
to toumorokoshi/aeps
that referenced
this pull request
Jan 10, 2024
* Adopt AEP-155: Idempotency * Address Yusuke's comments. * Update aep/general/0155/aep.md * lint * Qualify proto-specific guidance. * Update to reflect new common components and live discussion. * Minor rephrasing of list. * Clarify invalid `first_sent`. * Remove section about stale success responses.
toumorokoshi
pushed a commit
to toumorokoshi/aeps
that referenced
this pull request
Jan 24, 2024
* Adopt AEP-155: Idempotency * Address Yusuke's comments. * Update aep/general/0155/aep.md * lint * Qualify proto-specific guidance. * Update to reflect new common components and live discussion. * Minor rephrasing of list. * Clarify invalid `first_sent`. * Remove section about stale success responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty straightforward adoption of Google's AIP-155. The only substantial change is the renaming of the field from
request_idtoidempotency_key. See the new subsection of the Rationale section for an explanation.