Skip to content

Allow user fusion with payment users#979

Merged
Rotheem merged 4 commits intomainfrom
mypayment-user-fusion
Mar 18, 2026
Merged

Allow user fusion with payment users#979
Rotheem merged 4 commits intomainfrom
mypayment-user-fusion

Conversation

@Rotheem
Copy link
Member

@Rotheem Rotheem commented Mar 16, 2026

Description

Summary

Correctly fuse payment users during user fusion

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.43%. Comparing base (4282ad5) to head (0c7734f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/core/mypayment/cruds_mypayment.py 80.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage   84.42%   84.43%           
=======================================
  Files         205      206    +1     
  Lines       14881    14915   +34     
=======================================
+ Hits        12564    12593   +29     
- Misses       2317     2322    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Updated comment to clarify balance transfer logic.
@warix8
Copy link
Contributor

warix8 commented Mar 16, 2026

I think “merge” would be better than “fuse” even if it doesn't make a big difference.

Copy link
Contributor

@warix8 warix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but it seems perfectly fine to me

@Rotheem Rotheem merged commit 046f9dd into main Mar 18, 2026
7 checks passed
@Rotheem Rotheem deleted the mypayment-user-fusion branch March 18, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants