Repository navigation
Potential fix for code scanning alert no. 2: Clear text storage of sensitive information - #2
Merged
Merged
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
advanceddev
marked this pull request as ready for review
October 30, 2026 10:25
advanceddev
added a commit
that referenced
this pull request
Nov 1, 2026
+ separate storage keys + PersistedSession.connectItems & restore lastConnectItems + move bytesToBase64 & base64ToBytes to core/encoding.ts + INVALID_PAYLOAD instead of damaged urls + display actionSheet for signData (as for sendTransaction) + read TBridgeStorageSecret once + (qr) Path2D batch fill instead of fillRect for every module + action sheet: Escape + simple focus-trap by tab + console.warn for EventEmitter.emit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/advanceddev/tbridge-sdk/security/code-scanning/2
To fix this without changing external behavior more than necessary, store
secretKeyHexencrypted at rest whenever written tosessionStorage, and decrypt on read. In this file, the safest single-file approach is to add Web Crypto AES-GCM helpers and a per-origin key derivation from a caller-provided passphrase (via global), with graceful fallback (do not persist secret if crypto/key unavailable). Then update:readSessionStoragecall sites forSTORAGE_KEYS.SESSION_SECRETto use decrypting reader.writeSessionStoragecall sites forSTORAGE_KEYS.SESSION_SECRETto use encrypting writer.Concretely in
wallet/session.ts:getSessionEncryptionPassphrase().deriveAesKey(),encryptSecretForStorage(),decryptSecretFromStorage().readEncryptedSessionSecret()andwriteEncryptedSessionSecret().writeSessionStorage(..., secret)) with encrypted writer.SESSION_SECRETwith decrypting reader.This addresses all listed alert variants at the same sink location.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.