Repository navigation
Potential fix for code scanning alert no. 1: Clear text storage of sensitive information - #1
Merged
Merged
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
advanceddev
marked this pull request as ready for review
October 30, 2026 10:04
Owner
Author
|
Nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/advanceddev/tbridge-sdk/security/code-scanning/1
The best fix is to make the storage adapter responsible for transparent encryption at rest for values written to
localStorage, and transparent decryption on reads. This avoids changing higher-level session logic and addresses all variants at the shared sink (setItem) in one place.Concretely in
core/storage.ts:globalThis.__TBRIDGE_STORAGE_SECRET__) if present; otherwise use an ephemeral per-runtime fallback key (still better than plaintext-at-rest in storage, while keeping runtime functionality intact).enc:v1:) so reads can distinguish encrypted vs legacy plaintext.LocalStorageAdapter.setItemto encrypt beforelocalStorage.setItem.LocalStorageAdapter.getItemto decrypt when prefixed; return plaintext for legacy values to preserve backward compatibility.StorageAdaptercontract remainsstringin/out), so no changes are required inwallet/session.ts.This single adapter-level change fixes all reported variants that reach the same cleartext localStorage sink.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.