Conversation
This reverts commit 6c95b04.
…om/adobe/spectrum-web-components into caseyisonit/typescript-exploration
- Add ESLint 9.x and related plugins to root package.json - Remove ESLint dependencies from 1st-gen/package.json - Remove ESLint dependencies from 2nd-gen/package.json - Remove ESLint dependencies from example-project-rollup - All linting dependencies now managed at root level
- Add eslint-plugin-mdx for linting .md and .mdx files - Remove CONTRIBUTOR-DOCS from ESLint ignore list - Disable code block linting (docs contain partial code snippets) - Update research doc with markdown/MDX linting recommendations - Align css-custom-vars-viewer with root typescript-eslint version
- Add eslint-plugin-lit@2.1.1 with 15 rules for Lit template validation - Add eslint-plugin-wc@3.0.1 with 9 rules for Web Component correctness - Add documented browser globals for DOM, events, observers, network APIs - Remove unused eslint-formatter-pretty dependency - Pin all ESLint dependencies to exact versions (no carets) - Update all packages to latest stable versions: - @eslint/js: 9.39.2 - @typescript-eslint/*: 8.54.0 - eslint: 9.39.2 - eslint-config-prettier: 10.1.8 - eslint-plugin-jsonc: 2.21.0 - eslint-plugin-lit-a11y: 4.1.4 - eslint-plugin-mdx: 3.6.2 - eslint-plugin-simple-import-sort: 12.1.1 - eslint-plugin-storybook: 10.2.1 - jsonc-eslint-parser: 2.4.2
- Add eslint-plugin-jsdoc@62.5.0 with minimal rule set - Configure custom tags for Custom Elements Manifest (CEM): @element, @slot, @csspart, @cssproperty, @fires, @attr, @Attribute, @internal - Add additional browser globals for HTML element types: HTMLSlotElement, HTMLInputElement, HTMLButtonElement, etc. - Rules focus on consistency, not requiring docs everywhere: - check-alignment (error): Consistent asterisk alignment - check-indentation (warn): Consistent description indentation - check-param-names (error): Param names match function signature - check-tag-names (error): Only valid JSDoc/CEM tags - check-types (warn): Prefer lowercase primitives - require-param-description (warn): Encourage param descriptions - require-returns-description (warn): Encourage return descriptions - valid-types (warn): Valid type expressions
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -66,120 +67,120 @@ const chevronIcon: Record<string, () => TemplateResult> = { | |||
| * @fires sp-accordion-item-toggle - Announce that an accordion item has been toggled while allowing the event to be cancelled. | |||
There was a problem hiding this comment.
Syntax error in namepath: sp-accordion-item-toggle
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
2 participants
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.