fix(tag): update tag content color to match S2

[rubencarvalho]

Description

Corrects the tag content color in S2 Foundations by updating the system-theme-bridge token mapping from --spectrum-neutral-subdued-content-color-* to --spectrum-neutral-content-color-* for all interaction states (default, hover, active, focus). I also updated the border-color to match the content color for consistency with the other themes.

Before: Tag text rendered at gray-700 (~rgb 80,80,80) via --spectrum-neutral-subdued-content-color-default
After: Tag text renders at gray-800 (~rgb 41,41,41) via --spectrum-neutral-content-color-default

The change is isolated to 1st-gen/tools/styles/tokens-v2/system-theme-bridge.css, affecting only the S2 Foundations theme.

Motivation and context

It was reported via Slack that the tag content color in S2 Foundations does not match the S2 design spec. The "subdued" variant produces a noticeably lighter text color than intended, reducing contrast and deviating from the Figma token specs.

Related issue(s)

• fixes SWC-1356

Screenshots (if appropriate)

---

Author's checklist

• I have read the CONTRIBUTING and PULL_REQUESTS documents.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
• I have added automated tests to cover my changes.
• I have included a well-written changeset if my change needs to be published.
• I have included updated documentation if my change required it.

---

Reviewer's checklist

• Includes a Github Issue with appropriate flag or Jira ticket number without a link
• Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
• Automated tests cover all use cases and follow best practices for writing
• Validated on all supported browsers
• All VRTs are approved before the author can update Golden Hash

Manual review test cases

• Verify tag content color matches S2 spec in default state

  1. Go to the tag component Storybook page with S2 theme enabled
  2. Inspect the tag text color using browser dev tools
  3. Expect the computed color to resolve to gray-800 (rgb 41,41,41) via --spectrum-neutral-content-color-default

[changeset-bot]

🦋 Changeset detected

Latest commit: f2af50b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📚 Branch Preview Links

• Documentation Site (first-gen)
• Storybook (first-gen)
• Storybook (second-gen)

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• Spectrum | Light | Medium | LTR
• Spectrum | Dark | Large | RTL
• Express | Light | Medium | LTR
• Express | Dark | Large | RTL
• Spectrum-two | Light | Medium | LTR
• Spectrum-two | Dark | Large | RTL
• High Contrast Mode | Medium | LTR

Deployed to Azure Blob Storage: pr-6020

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

[marissahuysentruyt]

Love a quick fix! VRTs are expected ✅

Just a quick thought- in S1, the border color and the content color of the tags match. The request was just for the content color, so I'm going to approve, but would we want to update the border color to the same neutral-content-color-* tokens as well? I believe all of the other variants and states have matching border & content colors.

[marissahuysentruyt]

Beautiful!

Just left a non-blocking question about the changeset. 👍

[marissahuysentruyt]

Even though we only updated the mapping in tokens-v2, would you still consider this a patch for tag? Just curious so I know for the future if anything like this comes up again!

[rubencarvalho]

I try to frame changesets from the customer perspective. These will end up surfacing as the changelog for release, so they should describe the "product impact" they can expect after upgrading, not just internal implementation details.
Instead of “updated token mapping,” I'm trying to tell them more explicitly “what changed in the product experience?”, which in this case is a change in the tag component. Product's QA also look at these when assessing what to look for / what to test.