fix(utils): prevent FinalizationRegistry leak on every re-render in useId#9896
Closed
Gdhanush-13 wants to merge 1 commit intoadobe:mainfrom
Closed
fix(utils): prevent FinalizationRegistry leak on every re-render in useId#9896Gdhanush-13 wants to merge 1 commit intoadobe:mainfrom
Gdhanush-13 wants to merge 1 commit intoadobe:mainfrom
Conversation
registry.register() was called unconditionally in the render body, adding a new entry on every render. Since FinalizationRegistry.register() always adds a new entry (even with the same target), this leaked entries until the component unmounted. Fix: track the last registered id in a ref and only call register() when the id changes. Unregister the previous entry before re-registering. Fixes adobe#9852
Contributor
|
Duplicate of #9853 |
Gdhanush-13
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
registry.register(cleanupRef, res)inuseIdruns unconditionally in the render body, adding a newFinalizationRegistryentry on every re-render. SinceFinalizationRegistry.register()always adds a new entry (even with the same target), this leaks entries that are never cleaned up until the component unmounts.Any hook that calls
useIdinternally (e.g.useMenuTrigger) inherits this leak.Fix
Track the last registered id in a ref. Only call
register()whenreschanges, andunregister()the previous entry before re-registering. Also reset the ref on cleanup so remounted components re-register correctly.Fixes #9852