fix: skip native Date fast paths when local timezone is overridden (#9669)#9680
Closed
sonsu-lee wants to merge 1 commit intoadobe:mainfrom
Closed
fix: skip native Date fast paths when local timezone is overridden (#9669)#9680sonsu-lee wants to merge 1 commit intoadobe:mainfrom
sonsu-lee wants to merge 1 commit intoadobe:mainfrom
Conversation
…dobe#9669) `setLocalTimeZone` overrides the cached timezone string, but fast paths in `getTimeZoneOffset` and `toAbsolute` delegate to native `Date` which always uses the browser's real timezone. This causes incorrect offsets when the overridden timezone differs from the real one. Skip the fast paths when `setLocalTimeZone` has been called and not reset.
2 tasks
Contributor
Author
|
Closing in favor of #9678 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9669
✅ Pull Request Checklist:
📝 Test Instructions:
yarn jest packages/@internationalized/date/tests/
🧢 Your Project: