Skip to content

fix: Properly hide separator in Menu when next node is loader/null - #10609

Open
LFDanLu wants to merge 3 commits into
mainfrom
menu_testing_fixes
Open

LFDanLu wants to merge 3 commits into
mainfrom
menu_testing_fixes

Conversation

@LFDanLu

@LFDanLu LFDanLu commented Sep 16, 2026

Copy link
Copy Markdown
Member

From testing
Fixes the bug where the separator was appearing after the last section since we always render a loading node in S2
Also adds a set width to the async loading menu docs example so it doesn't resize as items are loader

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at CLAUDE.md.

📝 Test Instructions:

See chromatic. Test the menus with sections/combobox with sections/picker with sections and make sure no divider renders after the last item

🧢 Your Project:

RSP

@rspbot

rspbot commented Sep 16, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 16, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (10)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/705bbd3eea955f52bf3fcc278e31a9af00590316/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/705bbd3eea955f52bf3fcc278e31a9af00590316/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants