-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: preserve active FocusScope when sibling unmounts #10596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dvd233
wants to merge
1
commit into
adobe:main
Choose a base branch
from
dvd233:fix/focusscope-sibling-unmount-10593
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+121
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
packages/react-aria/test/focus/FocusScope.browser.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Copyright 2026 Adobe. All rights reserved. | ||
| * This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under | ||
| * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| import {expect, it} from 'vitest'; | ||
| import {FocusScope} from '../../src/focus/FocusScope'; | ||
| import React, {useState} from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import {render} from 'vitest-browser-react'; | ||
| import {userEvent} from 'vitest/browser'; | ||
|
|
||
| function Portal({children}: {children: React.ReactNode}) { | ||
| return ReactDOM.createPortal(children, document.body); | ||
| } | ||
|
|
||
| function SiblingScopes() { | ||
| let [showFirst, setShowFirst] = useState(true); | ||
| let [showSecond, setShowSecond] = useState(false); | ||
|
|
||
| let openSecond = () => { | ||
| setShowSecond(true); | ||
| setTimeout(() => setShowFirst(false), 50); | ||
| }; | ||
|
|
||
| return ( | ||
| <FocusScope contain restoreFocus> | ||
| <button>Outside</button> | ||
| {showFirst && ( | ||
| <Portal> | ||
| <FocusScope contain restoreFocus autoFocus> | ||
| <button onClick={openSecond}>Choose date and time</button> | ||
| </FocusScope> | ||
| </Portal> | ||
| )} | ||
| {showSecond && ( | ||
| <Portal> | ||
| <FocusScope contain restoreFocus autoFocus> | ||
| <button>September</button> | ||
| <button>2026</button> | ||
| <button>Next month</button> | ||
| </FocusScope> | ||
| </Portal> | ||
| )} | ||
| </FocusScope> | ||
| ); | ||
| } | ||
|
|
||
| it.each([ | ||
| {direction: 'forward', shift: false, expected: '2026'}, | ||
| {direction: 'reverse', shift: true, expected: 'Next month'} | ||
| ])( | ||
| 'keeps $direction Tab navigation in a sibling scope after unmount', | ||
| async ({shift, expected}) => { | ||
| let {getByRole} = await render(<SiblingScopes />); | ||
|
|
||
| await userEvent.click(getByRole('button', {name: 'Choose date and time'})); | ||
| await expect | ||
| .element(getByRole('button', {name: 'Choose date and time'})) | ||
| .not.toBeInTheDocument(); | ||
| await expect.element(getByRole('button', {name: 'September'})).toHaveFocus(); | ||
|
|
||
| await userEvent.tab({shift}); | ||
| await expect.element(getByRole('button', {name: expected})).toHaveFocus(); | ||
| } | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we asserting this? what does it tell us?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It tells us we are looking at slop. This test already passes on main without changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking that, I had a feeling that was the case but hadn't pulled it down yet. I appreciate the help, hopefully they'll look back over the PR and get it fixed up.
I'm not actually sure there is a bug yet, I'm unclear why they are using FocusScope directly, and not using Modal. #10593 (comment)